Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rh/update docs #373

Merged
merged 7 commits into from
Apr 9, 2024
Merged

Rh/update docs #373

merged 7 commits into from
Apr 9, 2024

Conversation

rodrigomha
Copy link
Contributor

Closes #293

@rodrigomha rodrigomha requested a review from jd-lara April 2, 2024 23:02
@rodrigomha rodrigomha self-assigned this Apr 2, 2024
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Performance Results

Version Precompile Time
Main 1.799615987
This Branch 1.798652995
Version Execute Time
Main-Build ResidualModel 7.795265115
Main-Execute ResidualModel 15.877780474
Main-Build MassMatrixModel 0.591592618
Main-Execute MassMatrixModel 30.298872784
This Branch-Build ResidualModel 6.637072926
This Branch-Execute ResidualModel 16.513532586
This Branch-Build MassMatrixModel 0.588011586
This Branch-Execute MassMatrixModel 30.214155505

ResidualModel and MassMatrixModel performance results should be compared between versions and not between models due to the execution order of the tests

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.34%. Comparing base (6a070cb) to head (e1b6acd).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
- Coverage   87.56%   87.34%   -0.22%     
==========================================
  Files          65       65              
  Lines        9156     9143      -13     
==========================================
- Hits         8017     7986      -31     
- Misses       1139     1157      +18     
Flag Coverage Δ
unittests 87.34% <ø> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

@rodrigomha
Copy link
Contributor Author

@rodrigomha rodrigomha merged commit c94d006 into main Apr 9, 2024
9 checks passed
@jd-lara jd-lara deleted the rh/update_docs branch May 9, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document Active Load Model
2 participants