Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jd/param update fixes #1139

Merged
merged 29 commits into from
Sep 24, 2024

bump pnm version

f637505
Select commit
Loading
Failed to load commit list.
Merged

Jd/param update fixes #1139

bump pnm version
f637505
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 23, 2024 in 0s

78.33% (+0.43%) compared to f7e83f4

View this Pull Request on Codecov

78.33% (+0.43%) compared to f7e83f4

Details

Codecov Report

Attention: Patch coverage is 33.76206% with 206 lines in your changes missing coverage. Please review.

Project coverage is 78.33%. Comparing base (f7e83f4) to head (f637505).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...rc/parameters/update_container_parameter_values.jl 34.76% 137 Missing ⚠️
src/parameters/update_cost_parameters.jl 0.00% 60 Missing ⚠️
.../operation/operation_model_simulation_interface.jl 65.00% 7 Missing ⚠️
src/parameters/update_parameters.jl 33.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1139      +/-   ##
==========================================
+ Coverage   77.89%   78.33%   +0.43%     
==========================================
  Files         118      121       +3     
  Lines       12700    12723      +23     
==========================================
+ Hits         9893     9966      +73     
+ Misses       2807     2757      -50     
Files with missing lines Coverage Δ
src/PowerSimulations.jl 100.00% <ø> (ø)
src/core/settings.jl 93.15% <100.00%> (+0.09%) ⬆️
src/operation/decision_model.jl 92.59% <100.00%> (+1.31%) ⬆️
src/operation/emulation_model.jl 86.40% <100.00%> (+0.40%) ⬆️
src/operation/operation_model_interface.jl 78.90% <100.00%> (+1.09%) ⬆️
src/parameters/update_parameters.jl 24.13% <33.33%> (-2.74%) ⬇️
.../operation/operation_model_simulation_interface.jl 65.00% <65.00%> (ø)
src/parameters/update_cost_parameters.jl 0.00% <0.00%> (ø)
...rc/parameters/update_container_parameter_values.jl 34.76% <34.76%> (ø)

... and 7 files with indirect coverage changes