-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jd/param update fixes #1139
Jd/param update fixes #1139
Conversation
…PowerSimulations.jl into jd/param_update_fixes
It seems that EmulationModel should also be updated for update_parameters to use SimulationState:
|
Performance Results
|
Export opt model setting
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1139 +/- ##
==========================================
+ Coverage 77.89% 78.33% +0.43%
==========================================
Files 118 121 +3
Lines 12700 12723 +23
==========================================
+ Hits 9893 9966 +73
+ Misses 2807 2757 -50
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…PowerSimulations.jl into jd/param_update_fixes
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, although I'm not sure of other impacts of this change.
No description provided.