Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jd/param update fixes #1139

Merged
merged 29 commits into from
Sep 24, 2024
Merged

Jd/param update fixes #1139

merged 29 commits into from
Sep 24, 2024

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Sep 9, 2024

No description provided.

@jd-lara jd-lara requested a review from rodrigomha September 9, 2024 19:55
@jd-lara jd-lara self-assigned this Sep 9, 2024
@rodrigomha
Copy link
Contributor

It seems that EmulationModel should also be updated for update_parameters to use SimulationState:

function update_parameters!(model::EmulationModel, data::DatasetContainer{InMemoryDataset})

Copy link
Contributor

github-actions bot commented Sep 9, 2024

Performance Results

Version Precompile Time
Main 3.43359204
This Branch 3.440024767
Version Build Time
Main-Build Time Precompile 54.553385343
Main-Build Time Postcompile 1.142841608
This Branch-Build Time Precompile 55.425487759
This Branch-Build Time Postcompile 1.264678896
Version Build Time
Main-Solve Time Precompile 703.688414182
Main-Solve Time Postcompile 685.515905764
This Branch-Solve Time Precompile 687.945511434
This Branch-Solve Time Postcompile 659.918717599

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 33.76206% with 206 lines in your changes missing coverage. Please review.

Project coverage is 78.33%. Comparing base (f7e83f4) to head (f637505).
Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
...rc/parameters/update_container_parameter_values.jl 34.76% 137 Missing ⚠️
src/parameters/update_cost_parameters.jl 0.00% 60 Missing ⚠️
.../operation/operation_model_simulation_interface.jl 65.00% 7 Missing ⚠️
src/parameters/update_parameters.jl 33.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1139      +/-   ##
==========================================
+ Coverage   77.89%   78.33%   +0.43%     
==========================================
  Files         118      121       +3     
  Lines       12700    12723      +23     
==========================================
+ Hits         9893     9966      +73     
+ Misses       2807     2757      -50     
Flag Coverage Δ
unittests 78.33% <33.76%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/PowerSimulations.jl 100.00% <ø> (ø)
src/core/settings.jl 93.15% <100.00%> (+0.09%) ⬆️
src/operation/decision_model.jl 92.59% <100.00%> (+1.31%) ⬆️
src/operation/emulation_model.jl 86.40% <100.00%> (+0.40%) ⬆️
src/operation/operation_model_interface.jl 78.90% <100.00%> (+1.09%) ⬆️
src/parameters/update_parameters.jl 24.13% <33.33%> (-2.74%) ⬇️
.../operation/operation_model_simulation_interface.jl 65.00% <65.00%> (ø)
src/parameters/update_cost_parameters.jl 0.00% <0.00%> (ø)
...rc/parameters/update_container_parameter_values.jl 34.76% <34.76%> (ø)

... and 7 files with indirect coverage changes

Copy link
Contributor

@rodrigomha rodrigomha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although I'm not sure of other impacts of this change.

@jd-lara jd-lara merged commit 86d9c12 into main Sep 24, 2024
8 of 9 checks passed
@jd-lara jd-lara deleted the jd/param_update_fixes branch September 27, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants