Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jd/fixes area balancing models #1130

Merged
merged 34 commits into from
Sep 9, 2024

fix tests

53fc090
Select commit
Loading
Failed to load commit list.
Merged

Jd/fixes area balancing models #1130

fix tests
53fc090
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 4, 2024 in 1s

77.89% (+0.45%) compared to b405b10

View this Pull Request on Codecov

77.89% (+0.45%) compared to b405b10

Details

Codecov Report

Attention: Patch coverage is 70.06369% with 47 lines in your changes missing coverage. Please review.

Project coverage is 77.89%. Comparing base (b405b10) to head (53fc090).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...s_models/device_constructors/branch_constructor.jl 69.23% 16 Missing ⚠️
...ices/common/objective_function/piecewise_linear.jl 0.00% 14 Missing ⚠️
src/devices_models/devices/area_interchange.jl 66.66% 6 Missing ⚠️
src/parameters/update_parameters.jl 42.85% 4 Missing ⚠️
src/core/parameters.jl 40.00% 3 Missing ⚠️
...vice_constructors/thermalgeneration_constructor.jl 96.55% 1 Missing ⚠️
src/devices_models/devices/AC_branches.jl 66.66% 1 Missing ⚠️
src/feedforward/feedforward_arguments.jl 50.00% 1 Missing ⚠️
.../simulation/initial_condition_update_simulation.jl 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1130      +/-   ##
==========================================
+ Coverage   77.44%   77.89%   +0.45%     
==========================================
  Files         118      118              
  Lines       12658    12700      +42     
==========================================
+ Hits         9803     9893      +90     
+ Misses       2855     2807      -48     
Files with missing lines Coverage Δ
...ce_constructors/renewablegeneration_constructor.jl 92.72% <100.00%> (ø)
...devices_models/devices/common/add_to_expression.jl 78.03% <ø> (ø)
src/devices_models/devices/electric_loads.jl 95.45% <100.00%> (ø)
src/feedforward/feedforward_constraints.jl 73.48% <ø> (+11.39%) ⬆️
src/initial_conditions/initialization.jl 96.72% <100.00%> (+0.05%) ⬆️
src/operation/time_series_interface.jl 63.63% <ø> (ø)
src/parameters/add_parameters.jl 65.65% <100.00%> (+0.35%) ⬆️
src/services_models/services_constructor.jl 97.60% <100.00%> (+13.90%) ⬆️
...vice_constructors/thermalgeneration_constructor.jl 98.30% <96.55%> (-0.01%) ⬇️
src/devices_models/devices/AC_branches.jl 81.20% <66.66%> (+0.13%) ⬆️
... and 7 more

... and 3 files with indirect coverage changes