Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jd/fixes area balancing models #1130

Merged
merged 34 commits into from
Sep 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
bc66c61
allow inter-area models for other network models
jd-lara Jul 16, 2024
57af12e
add missing code for initialization
jd-lara Jul 17, 2024
a6a9084
improve error message
jd-lara Jul 17, 2024
1c388a0
add missing feedforward calls
jd-lara Jul 19, 2024
f1323c2
add missing getters
jd-lara Jul 19, 2024
a9baa62
fix implementation errors in ff slacks
jd-lara Jul 19, 2024
9f3e4ad
remove assertion not required anymore
jd-lara Jul 19, 2024
222a4e6
fix template for initialization
jd-lara Jul 19, 2024
169bc19
parameter update bug fix
jd-lara Jul 19, 2024
bd97b54
change assertion for error message
jd-lara Jul 19, 2024
3581adc
add devices in the correct spot
jd-lara Jul 29, 2024
c357684
add devices missing
rodrigomha Jul 29, 2024
950fdb0
formatter
rodrigomha Jul 29, 2024
e5b304d
add subsystem to parameter attributes
jd-lara Jul 30, 2024
8e4ed7b
fix bad naming
jd-lara Jul 30, 2024
b6c8219
add missing constraints and arguments
jd-lara Jul 31, 2024
07b8f2b
fix FF problems
jd-lara Jul 31, 2024
6eaef2f
add missing method
jd-lara Jul 31, 2024
5b5bd74
add PSY predicate
jd-lara Jul 31, 2024
466362d
formatter
jd-lara Jul 31, 2024
228ff3c
add missing methods
jd-lara Aug 1, 2024
5662db1
formatter
jd-lara Aug 6, 2024
682d6a7
fix missing devices
jd-lara Aug 30, 2024
24368a9
remove duplicate add expression
rodrigomha Aug 30, 2024
93624fb
add missing arguments
jd-lara Aug 30, 2024
390123b
remove unavailable services from constructor
rodrigomha Aug 30, 2024
666ec92
add missing argument
jd-lara Aug 30, 2024
a1f762f
fix upper bound and lower bound
rodrigomha Aug 30, 2024
b3634e8
fix pwl nomin
rodrigomha Aug 30, 2024
bd8b958
add error for negative intercept
rodrigomha Aug 30, 2024
82f893e
Merge pull request #1136 from NREL-Sienna/rh/fix_multiple_bugs
jd-lara Sep 4, 2024
d3203e3
fix interchange overwrite
jd-lara Sep 4, 2024
192dc3c
add missing tests
jd-lara Sep 4, 2024
53fc090
fix tests
jd-lara Sep 4, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/core/parameters.jl
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
name::String
multiplier_id::Base.RefValue{Int}
component_name_to_ts_uuid::Dict{String, String}
subsystem::Base.RefValue{String}
end

function TimeSeriesAttributes(
Expand All @@ -18,6 +19,7 @@
name,
Base.RefValue{Int}(multiplier_id),
component_name_to_ts_uuid,
Base.RefValue{String}(""),
)
end

Expand All @@ -29,6 +31,13 @@
return
end

get_subsystem(attr::TimeSeriesAttributes) = attr.subsystem[]
function set_subsystem!(attr::TimeSeriesAttributes, val::String)
attr.subsystem[] = val
return

Check warning on line 37 in src/core/parameters.jl

View check run for this annotation

Codecov / codecov/patch

src/core/parameters.jl#L35-L37

Added lines #L35 - L37 were not covered by tests
end
set_subsystem!(::TimeSeriesAttributes, ::Nothing) = nothing

function add_component_name!(attr::TimeSeriesAttributes, name::String, uuid::String)
if haskey(attr.component_name_to_ts_uuid, name)
throw(ArgumentError("$name is already stored"))
Expand Down
Loading
Loading