Apply suggestions from code review

Co-authored-by: yuanxue2870 <[email protected]>
NOAA-EMC · Dec 12, 2024 · d398792 · d398792
1 parent 4836a93
commit d398792
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 0 deletions.
diff --git a/observations/snow/adpsfc_snow.yaml.j2 b/observations/snow/adpsfc_snow.yaml.j2
@@ -67,6 +67,10 @@
           name: GeoVaLs/vtype
         minvalue: 14.5
         maxvalue: 15.5
+    - filter: Difference Check # elevation check
+        reference: MetaData/stationElevation
+        value: GeoVaLs/filtered_orography
+        threshold: 200.
     - filter: BlackList
       where:
       - variable:

diff --git a/observations/snow/ghcn_snow.yaml.j2 b/observations/snow/ghcn_snow.yaml.j2
@@ -45,6 +45,10 @@
           name: GeoVaLs/vtype
         minvalue: 14.5
         maxvalue: 15.5
+    - filter: Difference Check # elevation check
+        reference: MetaData/stationElevation
+        value: GeoVaLs/filtered_orography
+        threshold: 200.
     - filter: Background Check
       filter variables:
       - name: totalSnowDepth

diff --git a/observations/snow/sfcsno.yaml.j2 b/observations/snow/sfcsno.yaml.j2
@@ -69,6 +69,10 @@
           name: GeoVaLs/vtype
         minvalue: 14.5
         maxvalue: 15.5
+    - filter: Difference Check # elevation check
+        reference: MetaData/stationElevation
+        value: GeoVaLs/filtered_orography
+        threshold: 200.
     - filter: BlackList
       where:
       - variable:

diff --git a/observations/snow/snocvr_snow.yaml.j2 b/observations/snow/snocvr_snow.yaml.j2
@@ -68,6 +68,10 @@
           name: GeoVaLs/vtype
         minvalue: 14.5
         maxvalue: 15.5
+    - filter: Difference Check # elevation check
+        reference: MetaData/stationElevation
+        value: GeoVaLs/filtered_orography
+        threshold: 200.
   obs post filters:
     - filter: Background Check # gross error check
       filter variables: