Apply suggestions from code review

Co-authored-by: Jiarui Dong <[email protected]>
NOAA-EMC · Dec 11, 2024 · 4836a93 · 4836a93
1 parent d91921b
commit 4836a93
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/observations/snow/adpsfc_snow.yaml.j2 b/observations/snow/adpsfc_snow.yaml.j2
@@ -54,7 +54,7 @@
       where:
       - variable:
           name: MetaData/stationElevation
-        minvalue: -999.0
+        value: is_valid
     - filter: Domain Check # land only
       where:
       - variable:

diff --git a/observations/snow/ghcn_snow.yaml.j2 b/observations/snow/ghcn_snow.yaml.j2
@@ -31,8 +31,8 @@
     - filter: Domain Check
       where:
       - variable:
-          name: MetaData/height
-        minvalue: -999.0
+          name: MetaData/stationElevation
+        value: is_valid
     - filter: Domain Check # land only
       where:
       - variable:

diff --git a/observations/snow/sfcsno.yaml.j2 b/observations/snow/sfcsno.yaml.j2
@@ -56,7 +56,7 @@
       where:
       - variable:
           name: MetaData/stationElevation
-        minvalue: -999.0
+        value: is_valid
     - filter: Domain Check # land only
       where:
       - variable:

diff --git a/observations/snow/snocvr_snow.yaml.j2 b/observations/snow/snocvr_snow.yaml.j2
@@ -55,7 +55,7 @@
       where:
       - variable:
           name: MetaData/stationElevation
-        minvalue: -999.0
+        value: is_valid
     - filter: Domain Check # land only
       where:
       - variable: