Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to 2DVar for snow DA + use JCB #1410

Merged
merged 28 commits into from
Dec 13, 2024
Merged

Conversation

CoryMartin-NOAA
Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA commented Dec 10, 2024

Closes #1324

This PR, combined with a companion workflow PR, switches the snow analysis to be 2DVar for both deterministic and ensemble mean, to use JCB to generate YAMLs and to leverage the g-w Jedi class. It also updates the IMS snow cover processing hash to use snodl instead of snwpdh

@CoryMartin-NOAA CoryMartin-NOAA marked this pull request as draft December 10, 2024 20:58
@CoryMartin-NOAA
Copy link
Contributor Author

This is in draft until NOAA-EMC/jcb-gdas#52 is merged and the hash is updated

@CoryMartin-NOAA
Copy link
Contributor Author

hash is updated, this is ready for review

Copy link
Collaborator

@jiaruidong2017 jiaruidong2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Just a minor question.

parm/snow/jcb-base.yaml.j2 Show resolved Hide resolved
Copy link
Collaborator

@YoulongXia-NOAA YoulongXia-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. I am not sure that you are using 2dvar or 3dvar?

parm/snow/jcb-prototype_2dvar.yaml.j2 Show resolved Hide resolved
@CoryMartin-NOAA CoryMartin-NOAA merged commit d9a1af6 into develop Dec 13, 2024
5 checks passed
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/snow-2dvar branch December 13, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to 2DVar for snow DA
3 participants