-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to 2DVar for snow DA + use JCB #1410
Conversation
This is in draft until NOAA-EMC/jcb-gdas#52 is merged and the hash is updated |
hash is updated, this is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. Just a minor question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good. I am not sure that you are using 2dvar or 3dvar?
Closes #1324
This PR, combined with a companion workflow PR, switches the snow analysis to be 2DVar for both deterministic and ensemble mean, to use JCB to generate YAMLs and to leverage the g-w Jedi class. It also updates the IMS snow cover processing hash to use
snodl
instead ofsnwpdh