Switch snow DA to use 2DVar for deterministic and ensemble mean #3163
+743
−824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e bias correction files from tarball (NOAA-EMC#2862)
Replace it with a direct read from BUFR at runtime.
…on files using jedi class (NOAA-EMC#2862)
…ns analysis scripts (NOAA-EMC#2862)
Co-authored-by: Jiarui Dong <[email protected]>
…tin-noaa/global-workflow into feature/snow-da-refactor
|
|
||
| export JCB_BASE_YAML="${PARMgfs}/gdas/snow/jcb-base.yaml.j2" | ||
| export JCB_ALGO_YAML_VAR="${PARMgfs}/gdas/snow/jcb-prototype_2dvar.yaml.j2" | ||
|
|
There was a problem hiding this comment.
Suggested change
| # Process IMS snowcover into snow depth | |
| export IMS_OBS_LIST="${PARMgfs}/gdas/snow/prep/prep_ims.yaml.j2" | |
| export CALCFIMSEXE="${EXECgfs}/calcfIMS.exe" | |
| export FIMS_NML_TMPL="${PARMgfs}/gdas/snow/prep/fims.nml.j2" | |
| export IMS2IODACONV="${USHgfs}/imsfv3_scf2ioda.py" | |
Add IMS process configures
| @@ -47,7 +47,7 @@ gdas_restarta: | |||
|
|
|||
| # Snow configuration yaml | |||
| {% if DO_JEDISNOWDA %} | |||
| - "{{ COMIN_CONF | relpath(ROTDIR) }}/{{ head }}letkfoi.yaml" | |||
| - "{{ COMIN_SNOW_ANALYSIS | relpath(ROTDIR) }}/{{ head }}snowanl.yaml" | |||
There was a problem hiding this comment.
Suggested change
| - "{{ COMIN_SNOW_ANALYSIS | relpath(ROTDIR) }}/{{ head }}snowanl.yaml" | |
| - "{{ COMIN_SNOW_ANALYSIS | relpath(ROTDIR) }}/{{ head }}snowanlvar.yaml" |
Keep consistent to the defined expected_keys = ['snowanlvar'] in ush/python/pygfs/task/snow_analysis.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the snow DA from a LETKF-OI approach with a fake ensemble to a 2DVar approach for the deterministic and the ensemble mean for GDAS/GFS. This PR also adds support for JCB and refactoring of the jobs to leverage the Jedi class in the workflow.
Resolves #3002
Type of change
Change characteristics
How has this been tested?
Checklist