-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few additions for the sea ice. #157
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dabail10 , thanks for making these additions!
I also have a few very minor change requests:
- Could you please title your notebooks something descriptive? Our recommended format is
<region>_<variable>_<metric>_<comparisons>.ipynb
; for instance, this might look likeGlobal_PSL_NMSE_compare_obs_lens.ipynb
orGreenland_SMB_visual_compare_obs.ipynb
. - It looks like there is some commented out code in both of the notebooks-- if this is not going to be used, can you please remove it? Or, if the commented out code is going to be used in some circumstances, maybe it could be in a in 'if' statement?
I have addressed the first part. I need some of the commented out code as I want to use this eventually for reading the LENS data. |
I have got this to work (at least read data) with the examples/key_metrics/config.yml file. I am still working on the computing of an annual average. The new way of reading in the datasets messed up my resample/groupby. More to come. |
Description of changes:
pre-commit
checks passed (#8 in Adding Notebooks Guide)?