Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few additions for the sea ice. #157

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Remove some print statements

a28e25e
Select commit
Loading
Failed to load commit list.
Open

A few additions for the sea ice. #157

Remove some print statements
a28e25e
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded Dec 6, 2024 in 0s

6 / 6 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
Have you followed the guidelines in our Contributor's Guide? Completed
Have you checked to ensure there aren't other open Pull Requests for the same update/change? Completed
Have you made sure that the pre-commit checks passed (#8 in Adding Notebooks Guide)? Completed
Have you hidden the code cells (#8 in Adding Notebooks Guide) in your notebook? Completed
Have you added an explanation of what your changes do and why you'd like us to include them? Completed
Have you successfully tested your changes locally? Completed
Added new Hemis_seaice_visual_compare_obs_lens.ipynb which is a start to the sea ice key metrics. Incomplete
modified the list of variables for the seaice notebook to make it faster. There is a new cice_vars_full.yml list Incomplete
updated the sea ice runs in config.yml Incomplete
changed the color table Incomplete
fixed the options for the cluster Incomplete
to do: configure the config.yml for sea ice in the key_metrics directory Incomplete
Could you please title your notebooks something descriptive? Our recommended format is <region>_<variable>_<metric>_<comparisons>.ipynb; for instance, this might look like Global_PSL_NMSE_compare_obs_lens.ipynb or Greenland_SMB_visual_compare_obs.ipynb. Incomplete
It looks like there is some commented out code in both of the notebooks-- if this is not going to be used, can you please remove it? Or, if the commented out code is going to be used in some circumstances, maybe it could be in a in 'if' statement? Incomplete
Could you please title your notebooks something descriptive? Our recommended format is <region>_<variable>_<metric>_<comparisons>.ipynb; for instance, this might look like Global_PSL_NMSE_compare_obs_lens.ipynb or Greenland_SMB_visual_compare_obs.ipynb. Incomplete
It looks like there is some commented out code in both of the notebooks-- if this is not going to be used, can you please remove it? Or, if the commented out code is going to be used in some circumstances, maybe it could be in a in 'if' statement? Incomplete
View more details on Task list completed