Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMIP6 files #323

Merged
merged 11 commits into from
Oct 6, 2023
Merged

Add CMIP6 files #323

merged 11 commits into from
Oct 6, 2023

Conversation

abarciauskas-bgse
Copy link
Contributor

Adding content

Content checklist

Check the Content Documentation for more details.

Any content

  • Cover image with proper attribution (when relevant) is present.
  • Cover images do not contain any text (they're used as a background and text may not be readable).
  • All images are not too big/heavy. As a general rule of thumb, they should not weigh more than 500KB, or be larger than 2000px. See the media guide for more info.
  • Content was added using the available MDX Blocks.

Datasets

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for visex ready!

Name Link
🔨 Latest commit 244fad3
🔍 Latest deploy log https://app.netlify.com/sites/visex/deploys/651f29ed98ab6f0008908b9e
😎 Deploy Preview https://deploy-preview-323--visex.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@abarciauskas-bgse
Copy link
Contributor Author

@slesaad @j08lue @danielfdsilva @hanbyul-here I'm seeing an error from the deploy preview: https://deploy-preview-323--visex.netlify.app/data-catalog/combined_CMIP6_daily_GISS-E2-1-G_tas_kerchunk_DEMO/explore

Warning: Received true for a non-boolean attribute on.

If you want to write it to the DOM, pass a string instead: on="true" or on={value.toString()}.
article

which I thought may driven by something in the MDX file so I changed a few things but it hasn't resolved the issue. Do you have any pointers for debugging this? I'm not seeing it locally with veda-ui

Locally I can see this traceback:

T@https://deploy-preview-323--visex.netlify.app/index.fcca913e.js:14:286605
T@https://deploy-preview-323--visex.netlify.app/index.fcca913e.js:14:286605
u<@https://deploy-preview-323--visex.netlify.app/s-explore.a502d860.js:123:93
b/<@https://deploy-preview-323--visex.netlify.app/index.fcca913e.js:33:1837
x/<@https://deploy-preview-323--visex.netlify.app/index.fcca913e.js:33:6463
x@https://deploy-preview-323--visex.netlify.app/s-explore.a502d860.js:109:68
li
ol
T@https://deploy-preview-323--visex.netlify.app/index.fcca913e.js:14:286605
g@https://deploy-preview-323--visex.netlify.app/mdx-content.2e230bff.js:178:4077
h@https://deploy-preview-323--visex.netlify.app/s-explore.a502d860.js:62:79
div

@abarciauskas-bgse
Copy link
Contributor Author

@anayeaye pointed me to codespaces https://github.com/NASA-IMPACT/veda-config/blob/develop/docs/GH_CODESPACES.md so I will try troubleshooting there if no one has any other ideas as to what could be going wrong.

@slesaad
Copy link
Member

slesaad commented Oct 5, 2023

@abarciauskas-bgse took me a while to figure out 😅 but the .env is missing the titiler xarray endpoint

datasets/cmip6-tas.data.mdx Outdated Show resolved Hide resolved
@hanbyul-here
Copy link
Collaborator

@abarciauskas-bgse I can confirm that this error was not introduced by the change of this PR. We have been aware of the error but have been pushing off because of the other priorities. so please ignore it for now. I will ticket this and handle.

@abarciauskas-bgse
Copy link
Contributor Author

@slesaad 🙇🏽‍♀️ thank you so much

how did you track it down?

I believe this PR is now good to go. I slightly modified the text in the last section of the dataset description (see 244fad3) so let me know if that content looks good to you @slesaad @j08lue

Copy link
Contributor

@j08lue j08lue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @abarciauskas-bgse!

@slesaad
Copy link
Member

slesaad commented Oct 6, 2023

@abarciauskas-bgse I noticed that the network request wasn't being made at all

also noticed that the provider URL in the collection metadata is "https://github.com/nasa-impact/veda-data-pipelines". We're no longer using that repository, so I'm kinda hesitant about putting that there.

But this PR looks good!

@abarciauskas-bgse abarciauskas-bgse merged commit 68a9134 into develop Oct 6, 2023
5 checks passed
@abarciauskas-bgse abarciauskas-bgse deleted the dataset/cmip6-kerchunk-demo branch October 6, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants