-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to analysis page from the feedback #751
Conversation
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
One thing missing: Port modal to view tile endpoints @danielfdsilva |
Needed while the code is not deleted to prevent ts errors
If we release this first on VEDA, I guess we will need to have this support, since we have a dataset there that relies on TiTiler-Xarray: NASA-IMPACT/veda-config#323 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The three most visible improvements
Connects the data-catalog to exploration by filtering the dataset selector modal by the veda dataset name
Removes connections to previous analysis and dataset explore pages
Add info icon to dataset #747
Are very nicely done and seem to work well.
Not sure how to reproduce the bug with analysis range out of bounds - I think this was caused by running an analysis on a different dataset/layer, then switching while it was still active...? I trust that the fix is helpful either way and we will see whether this issue occurs again in any subsequent testing.
We should revisit the list of showstoppers for a release in US-GHG-Center/veda-config-ghg#221 (comment) and add any new ones that have up, but this closes some of the main ones.
@j08lue Alright, I'll port the zarr viz as well. Should be pretty easy since it is only a layer component. For completion, to replicate the range error on the non fixed version:
The bug is that the range will remain in 2020, even though the remaining dataset (NPP) only has data up to 2018. This no longer happens in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got some questions/ noticed some items that are not necessarily related to this pr (nothing blocker)
-
What is the expected behavior for vector, zarr. layer for 'analysis' ? I don't actually know if analysis endpoint works the same for these different layers. Probably @j08lue can answer this question?
-
I noticed that people are just repeating the same layer (with the same ids) to populate the layers in different datasets ex. mtbs-burn-severity . It seems we rely layer id to component key here and there, ends up warning about the duplicate keys.
-
Since we introduced 'stacApiEndpoint' for layers, we probably can get rid of XARRRAY_ENDPOINT: https://github.com/NASA-IMPACT/veda-config/blob/develop/.env#L15 from env, and move this info to zarr layer mdx file.
Great review comments, @hanbyul-here.
Regarding Analysis on TiTiler-Xarray datasets: no this functionality ( We need to look into implementing that functionality, but it is also ok that it does not exist - the TiTiler-Xarray dataset is advertised as experimental anyways. |
|
Will merge this and make the remaining tweaks on a separate PR |
Contributes to US-GHG-Center/veda-config-ghg#221 to get us close to a delivery state.
Includes the work done in #744 plus changes so that custom api endpoints are supported in the exploration page.
Besides the former: