Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Translations #681

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

fredericsimard
Copy link
Contributor

Summary:

Translated the UI labels in 10 languages, did manual fixes on mistakes added by translator.

@fredericsimard fredericsimard added the enhancement New feature or request label Aug 15, 2024
@fredericsimard fredericsimard self-assigned this Aug 15, 2024
Copy link

Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-681-pv9a1bn8.web.app

@fredericsimard fredericsimard requested a review from emmambd August 15, 2024 12:14
@fredericsimard fredericsimard changed the title Translations Feat: Translations Aug 15, 2024
Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! As this repository is in active development, let's make sure that we create a development process that is easy to follow. It might be great if we introduce a way in the process to override text generated by the tool with community fixed text. Before making this public, we should implement the search in multiple languages as @emmambd suggested. I also suggest adding a disclaimer text pointing out the process to contribute to translations.

web-app/public/locales/es/account.json Outdated Show resolved Hide resolved
web-app/public/locales/fr/common.json Show resolved Hide resolved
@fredericsimard
Copy link
Contributor Author

@davidgamez I can install the automation to do the translation when a PR is opened for these specific files and then added to the PR for someone to revise and change what needs to. It's untested in prod but should work. I was waiting for the new gtfs.org website to be online before installing it there, but it's ready.

@davidgamez
Copy link
Member

@davidgamez I can install the automation to do the translation when a PR is opened for these specific files and then added to the PR for someone to revise and change what needs to. It's untested in prod but should work. I was waiting for the new gtfs.org website to be online before installing it there, but it's ready.

Let's connect to go over the details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants