Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add/remove vscode configurations and update dependencies #395

Merged
merged 18 commits into from
Oct 12, 2023
Merged

feat: add/remove vscode configurations and update dependencies #395

merged 18 commits into from
Oct 12, 2023

Conversation

peterhnm
Copy link
Member

@peterhnm peterhnm commented Sep 20, 2023 •
edited
Loading

Issue

Description

Add a configuration to enable the alignment of the diagram at the origin.

To test it:

  1. Open the settings (Code > Preferences > Settings)
  2. Search for "Miranum IDE"
  3. Toggle the checkbox
  4. Open a bpmn diagram and test the alignment

Checklist

  • Code is easy to understand
  • No obvious errors or bugs
  • CI/CD Pipelines did run successfully
  • Tests were implemented
  • Documentation was created

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@peterhnm peterhnm changed the title feat(modeler): modeler alignment config feat: add/remove vscode configurations and update dependencies Sep 20, 2023
@peterhnm peterhnm linked an issue Sep 27, 2023 that may be closed by this pull request
[Bug] - Resizing the pool causes buggy editor #385
Closed
@peterhnm peterhnm requested a review from Hafflgav October 4, 2023 13:48
@peterhnm
Merge branch 'main' into feat/modeler_alignment_config
e966699 
# Conflicts:
#	package-lock.json
#	package.json
@peterhnm peterhnm removed the request for review from Hafflgav October 4, 2023 14:00
@peterhnm peterhnm requested a review from Hafflgav October 4, 2023 14:20
@peterhnm
Merge branch 'main' into feat/modeler_alignment_config
f2cd397 
# Conflicts:
#	package-lock.json
#	package.json
Hafflgav
Hafflgav approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@Hafflgav Hafflgav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! Works perfectly fine on my machine. 👍
Thank you for adding this improvement! 💯

@peterhnm peterhnm merged commit 7a45044 into main Oct 12, 2023
2 checks passed
@peterhnm peterhnm deleted the feat/modeler_alignment_config branch October 12, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hafflgav Hafflgav Hafflgav approved these changes

Assignees
No one assigned
Labels
miranum-cli NPM release miranum-console miranum-extension-pack miranum-modeler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] - Resizing the pool causes buggy editor
3 participants
@peterhnm @codecov-commenter @Hafflgav