Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] - Resizing the pool causes buggy editor #385

Closed
Hafflgav opened this issue Sep 17, 2023 · 3 comments · Fixed by #394 or #395
Closed

[Bug] - Resizing the pool causes buggy editor #385

Hafflgav opened this issue Sep 17, 2023 · 3 comments · Fixed by #394 or #395
Assignees
Labels
bug Something isn't working

Comments

@Hafflgav
Copy link
Contributor

Hafflgav commented Sep 17, 2023

Describe the bug
When I open a BPMN model in the VS Code Modeler and I want to resize the pool, the behaviour shown in the video occurs.
It can be forced by expanding the pool to the top. Sometimes though, it happens in any given direction.
It was a bit unfortunate to experience this behaviour during a live demo of our VS Code Modeler. 😢

To Reproduce
Steps to reproduce the behavior:

  1. Open a BPMN file in the VS-Code Modeler
  2. Resize the pool in any given direction
  3. If it does not show the behaviour shown in the video redo step 2
  4. See behaviour which is shown in the video

Expected behaviour
Resizing of a pool does not cause the Modeler to reset view point to a white canvas. Editing the size of the pool should be always possible

Screenshots
Video:
video of the bug

Desktop (please complete the following information):

  • OS: macOS 13.5.2 (22G91)
  • VS Code Version: 1.82.1
  • Miranum Modeler: v0.5.3
@Hafflgav Hafflgav added the bug Something isn't working label Sep 17, 2023
@Hafflgav Hafflgav moved this to 🆕 New in Miranum Board Sep 17, 2023
@peterhnm peterhnm moved this from 🆕 New to 🏗 In progress in Miranum Board Sep 18, 2023
@peterhnm peterhnm self-assigned this Sep 18, 2023
@peterhnm
Copy link
Member

The bug occurs because of this module.
It is described here

@peterhnm peterhnm linked a pull request Sep 19, 2023 that will close this issue
@peterhnm peterhnm moved this from 🏗 In progress to 👀 In review in Miranum Board Sep 19, 2023
@Hafflgav
Copy link
Contributor Author

Hey @peterhnm 👋
Thanks for the very fast fix of the problem 🚀
It doesn't crash anymore 👍

But besides, I have found another behaviour related to the viewport, which was a bit unexpected to me:

Miranum IDE Behaviour

My expectation would be that the viewport does not change when placing a BPMN-Element on the modelling canvas.
This behaviour can especially be seen when moving only start event on the canvas.

Let me know what you think about this!

@peterhnm
Copy link
Member

I like this behavior because it means less scrolling for me, for example after a resize of a pool.

What do you think about configuring it so that the user can turn this behavior on and off?

alignToOrigin.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
2 participants