Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback implementation #172

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Feedback implementation #172

merged 3 commits into from
Oct 7, 2024

Conversation

ravimeijerrig
Copy link
Collaborator

@ravimeijerrig ravimeijerrig commented Oct 1, 2024 •
edited
Loading

Description

With this PR we implement the following feedback:

  • add sources to question 4.0 and 4.1
  • Switch 5.1.0 and 5.1.1.
  • Alter some use of language
  • Add context to conclusion 13.2.3 en 13.2.1

Resolves #

@ravimeijerrig ravimeijerrig force-pushed the feature/legal_feedback branch from 288ba6d to dcdfd07 Compare October 2, 2024 07:31
GuusjeJuijn
GuusjeJuijn previously approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@GuusjeJuijn GuusjeJuijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some small comments

decision-tree.yaml Outdated Show resolved Hide resolved
decision-tree.yaml Outdated Show resolved Hide resolved
decision-tree.yaml Outdated Show resolved Hide resolved
@ravimeijerrig ravimeijerrig marked this pull request as ready for review October 4, 2024 14:04
laurensWe
laurensWe approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@laurensWe laurensWe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to remark :)

@laurensWe laurensWe merged commit c58217e into main Oct 7, 2024
4 checks passed
@laurensWe laurensWe deleted the feature/legal_feedback branch October 7, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurensWe laurensWe laurensWe approved these changes

@GuusjeJuijn GuusjeJuijn GuusjeJuijn left review comments

@ruthkoole ruthkoole Awaiting requested review from ruthkoole ruthkoole is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ravimeijerrig @laurensWe @GuusjeJuijn