-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/rolling spectrums #191
Conversation
Codecov Report
@@ Coverage Diff @@
## development #191 +/- ##
===============================================
+ Coverage 61.82% 61.84% +0.02%
===============================================
Files 34 34
Lines 2656 2857 +201
===============================================
+ Hits 1642 1767 +125
- Misses 1014 1090 +76
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
added import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not going to point out all the same stuff as the other PR (yet), just calling out a few things that are unique to this one.
…ome more plot options
…type for peak frequency
@CFlaniganMide let me know when you want to review this, I have the unit tests in there now and am curious how well written you think they are? |
@CFlaniganMide I think I've done everything now correctly, but let me know of course if not! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, also requesting some issues get made to flesh out some of the unit tests at a later date but they're good enough as-is.
Added! #192 |
Lots in this!
rolling_fft
toendaq.calc.fft
rolling_psd
toendaq.calc.psd
rolling_shock_spectrum
toendaq.calc.shock
spectrum_over_time
toendaq.plot.plots
octave_spectrogram
This would close / address: #189, #35, #156,
This specific branch is tested in this colab with lots of examples