Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Output with shock_spectrum() #219

Open
LifeDay opened this issue May 2, 2023 · 3 comments
Open

Inconsistent Output with shock_spectrum() #219

LifeDay opened this issue May 2, 2023 · 3 comments

Comments

@LifeDay
Copy link

LifeDay commented May 2, 2023

I have been noticing some inconsistency with the behavior of shock_spectrum() with aggregate_axis = True. When the dataset is short, shock_spectrum outputs only the “Resultant” column. When the dataset is longer, shock_spectrum outputs the “X”, “Y”, “Z”, and “Resultant” columns.

I believe the inconsistency was introduced in PR-191 (#191).

The intended behavior should be documented and the shock_spectrum() and rolling_shock_spectrum() corrected to match.

@StokesMIDE
Copy link
Member

@LifeDay Thanks for the report!

I will look into this and attempt to reproduce the issue. Approximately, how long were your 'short' and 'long' recordings?

@LifeDay
Copy link
Author

LifeDay commented May 2, 2023

@StokesMIDE The long sample had 388679 entries. The short sample had 3998 entries.

@LifeDay
Copy link
Author

LifeDay commented Feb 26, 2024

@StokesMIDE Is there any additional information I can provide to get this moving?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants