feat: [UX-332] Add multiselect support #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@witwash can refactoring be done as a separate PR to make this PR smaller? |
|
@ookami-kb, here is just the |
|
@witwash ah, I thought you could do refactoring PR with extracting some "future"-common part as a pre-step. |
|
@ookami-kb, can you look at this one please? 🙏 |
ookami-kb
approved these changes
Oct 17, 2023
optimus/lib/src/select_input.dart
Outdated
| @@ -90,6 +92,14 @@ class OptimusSelectInput<T> extends StatefulWidget { | |||
| /// {@endtemplate} | |||
| final GroupBuilder? groupBuilder; | |||
|
|
|||
| /// Whether to enable having several items selected at the same time. | |||
There was a problem hiding this comment.
I would rephrase it to something like
If
true, you can select multiple items at the same time.
optimus/lib/src/select_input.dart
Outdated
| @@ -90,6 +92,14 @@ class OptimusSelectInput<T> extends StatefulWidget { | |||
| /// {@endtemplate} | |||
| final GroupBuilder? groupBuilder; | |||
|
|
|||
| /// Whether to enable having several items selected at the same time. | |||
| /// State of the selected items is manages outside this widget and has to be | |||
There was a problem hiding this comment.
Suggested change
| /// State of the selected items is manages outside this widget and has to be | |
| /// State of the selected items is managed outside this widget and has to be |
| bool get _isUsingInlineError => | ||
| widget.errorVariant == OptimusInputErrorVariant.inlineTooltip; | ||
|
|
||
| void _onStateUpdate() => setState(() {}); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
multiselectsupport for theOptimusSelectInputOptimusSelectInputVideo
CleanShot.2023-10-09.at.22.49.57.mp4
Testing steps
Select InputstorymultiselectFollow-up issues
Refactoring 🔧
Check during review