Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update Chip gestures #446

Merged
merged 1 commit into from
Oct 4, 2023
Merged

feat: Update Chip gestures #446

merged 1 commit into from
Oct 4, 2023

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Oct 3, 2023 •
edited
Loading

Summary

  • Added onTap gesture to the OptimusChip body. Is needed for finishing SelectInput multiselect variant.

Testing steps

None

Follow-up issues

#448

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash marked this pull request as ready for review October 3, 2023 08:13
@witwash witwash requested a review from a team October 3, 2023 08:13
@witwash
Copy link
Contributor Author

witwash commented Oct 4, 2023

@ookami-kb, 🙏

@witwash witwash merged commit dd3d6c9 into master Oct 4, 2023
@witwash witwash deleted the chip-update branch October 4, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ookami-kb ookami-kb ookami-kb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witwash @ookami-kb