Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix mongodb extractor test #994

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

usefulalgorithm
Copy link
Contributor

🤔 Why?

Some collections are causing mongoimport to run incompletely, thus making the test pipeline unstable.

🤓 What?

  • Removed wacky test sample collections.
  • Updated expected test file.

🧪 Tested?

Ran the test 5 times after the the new expected file was updated, does not seem flakey.

Copy link

github-actions bot commented Oct 1, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
12809 11458 89% 85% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 42e67a9 by action🐍

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.45%. Comparing base (576d867) to head (42e67a9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #994   +/-   ##
=======================================
  Coverage   89.45%   89.45%           
=======================================
  Files         196      196           
  Lines       12809    12809           
=======================================
  Hits        11458    11458           
  Misses       1351     1351           
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@usefulalgorithm usefulalgorithm merged commit 460066e into main Oct 1, 2024
6 checks passed
@usefulalgorithm usefulalgorithm deleted the chore/fix-mongodb-extractor-test branch October 1, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants