-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sc-28944] Provide config to link user name to email #987
Closed
usefulalgorithm
wants to merge
6
commits into
main
from
tsung-julii/sc-28944/add-userid-email-config-in-crawler-config
Closed
[sc-28944] Provide config to link user name to email #987
usefulalgorithm
wants to merge
6
commits into
main
from
tsung-julii/sc-28944/add-userid-email-config-in-crawler-config
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #987 +/- ##
=======================================
Coverage 89.39% 89.40%
=======================================
Files 193 193
Lines 12591 12600 +9
=======================================
+ Hits 11256 11265 +9
Misses 1335 1335
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
elic-eon
reviewed
Sep 24, 2024
elic-eon
previously approved these changes
Sep 24, 2024
…add-userid-email-config-in-crawler-config
elic-eon
reviewed
Sep 24, 2024
elic-eon
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Why?
It's not possible to get the correspondence between user names and emails from Redshift or Postgres, we need user to provide this as a config value.
🤓 What?
Add config field
username_to_email
in query log conifgs.🧪 Tested?
☑️ Checks
pyproject.toml
.