Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sc-28944] Provide config to link user name to email #987

Conversation

usefulalgorithm
Copy link
Contributor

🤔 Why?

It's not possible to get the correspondence between user names and emails from Redshift or Postgres, we need user to provide this as a config value.

🤓 What?

Add config field username_to_email in query log conifgs.

🧪 Tested?

  • Modified unit tests.
  • Ran crawler locally.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link

github-actions bot commented Sep 24, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
12600 11265 89% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/kafka/config.py 97% 🟢
metaphor/postgresql/config.py 100% 🟢
metaphor/postgresql/extractor.py 55% 🟢
metaphor/redshift/extractor.py 74% 🟢
TOTAL 81% 🟢

updated for commit: a7bd198 by action🐍

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.40%. Comparing base (026c102) to head (a7bd198).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #987   +/-   ##
=======================================
  Coverage   89.39%   89.40%           
=======================================
  Files         193      193           
  Lines       12591    12600    +9     
=======================================
+ Hits        11256    11265    +9     
  Misses       1335     1335           
Flag Coverage Δ
89.40% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

elic-eon
elic-eon previously approved these changes Sep 24, 2024
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants