[sc-28750] Set ignore_command_statement default to False
#984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
mars-lan
reviewed
Sep 18, 2024
elic-eon
reviewed
Sep 18, 2024
usefulalgorithm
deleted the
tsung-julii/sc-28750/metaphor-crawler-big-query-integrations-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Why?
ignore_command_statementwas defaulted to True, which made all crawlers that parses SQL queries in all environments started processing queries.Instead of doing it by default, our users should explicitly opt-in to query processing.
The actual SQL query that could not be parsed by sqlglot is tracked in a separate ticket
🤓 What?
ignore_command_statementdefault toFalse🧪 Tested?
Modified unit test.
☑️ Checks
pyproject.toml.