Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logs for dbt cloud crawler #982

Merged
merged 5 commits into from
Sep 10, 2024

Conversation

elic-eon
Copy link
Contributor

@elic-eon elic-eon commented Sep 10, 2024

🤔 Why?

For the ease of debugging.

🤓 What?

  • Logs GQL calls

🧪 Tested?

Verified locally

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link

github-actions bot commented Sep 10, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11960 10653 89% 85% 🟢

New Files

File Coverage Status
metaphor/dbt/cloud/http.py 92% 🟢
TOTAL 92% 🟢

Modified Files

File Coverage Status
metaphor/dbt/cloud/extractor.py 89% 🟢
TOTAL 89% 🟢

updated for commit: 0a965fb by action🐍

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 92.10526% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.07%. Comparing base (9ebb5a7) to head (0a965fb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
metaphor/dbt/cloud/http.py 91.89% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #982   +/-   ##
=======================================
  Coverage   89.06%   89.07%           
=======================================
  Files         184      185    +1     
  Lines       11922    11960   +38     
=======================================
+ Hits        10618    10653   +35     
- Misses       1304     1307    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mars-lan
mars-lan previously approved these changes Sep 10, 2024
@elic-eon elic-eon dismissed stale reviews from mars-lan and usefulalgorithm via f4b8dd7 September 10, 2024 15:31
mars-lan
mars-lan previously approved these changes Sep 10, 2024
@elic-eon elic-eon enabled auto-merge (squash) September 10, 2024 15:36
@elic-eon elic-eon merged commit f92e2d1 into main Sep 10, 2024
4 checks passed
@elic-eon elic-eon deleted the scotthuang/sc-28635/dbt-tests-are-missing branch September 10, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants