Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sc-28620] Catch RecursionError in TLL parsing #981

Conversation

usefulalgorithm
Copy link
Contributor

🤔 Why?

We should catch RecursionError in the try catch block so that the crawler does not fail midway through the process.

🤓 What?

Catch RecursionError in TLL parsing.

🧪 Tested?

Tested locally.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link

github-actions bot commented Sep 9, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11922 10618 89% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/common/sql/table_level_lineage/table_level_lineage.py 82% 🟢
TOTAL 82% 🟢

updated for commit: e62632e by action🐍

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.06%. Comparing base (fddb6a9) to head (e62632e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...mon/sql/table_level_lineage/table_level_lineage.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #981      +/-   ##
==========================================
- Coverage   89.08%   89.06%   -0.03%     
==========================================
  Files         184      184              
  Lines       11919    11922       +3     
==========================================
  Hits        10618    10618              
- Misses       1301     1304       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@usefulalgorithm usefulalgorithm merged commit 9ebb5a7 into main Sep 9, 2024
4 of 6 checks passed
@usefulalgorithm usefulalgorithm deleted the tsung-julii/sc-28620/aaalife-redshift-maximum-recursion-depth branch September 9, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants