Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle crawler timeout gracefully #980

Merged

Conversation

elic-eon
Copy link
Contributor

@elic-eon elic-eon commented Sep 6, 2024

🤔 Why?

Factor out arg parsing to a function so we can call it from the launcher script to write a run.metadata when time out

🤓 What?

  • Factor out arg parsing
  • Update .dockerignore

🧪 Tested?

Deploy crawler image to dev with this change, and it will create run.metadata

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link

github-actions bot commented Sep 6, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11919 10618 89% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/main.py 0% 🟢
metaphor/common/cli.py 71% 🟢
TOTAL 35% 🟢

updated for commit: a6cec4e by action🐍

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 89.08%. Comparing base (c770e37) to head (a6cec4e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
metaphor/common/cli.py 28.57% 5 Missing ⚠️
metaphor/__main__.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #980      +/-   ##
==========================================
- Coverage   89.09%   89.08%   -0.02%     
==========================================
  Files         184      184              
  Lines       11915    11919       +4     
==========================================
+ Hits        10616    10618       +2     
- Misses       1299     1301       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mars-lan
mars-lan previously approved these changes Sep 6, 2024
@elic-eon elic-eon enabled auto-merge (squash) September 6, 2024 16:21
@elic-eon elic-eon disabled auto-merge September 6, 2024 16:25
@elic-eon elic-eon merged commit fddb6a9 into main Sep 6, 2024
4 of 6 checks passed
@elic-eon elic-eon deleted the scotthuang/sc-28248/handle-crawler-timeout-gracefully branch September 6, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants