Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sc-27944] Do not populate dataset in Tableau crawler #979

Conversation

usefulalgorithm
Copy link
Contributor

🤔 Why?

Tableau crawler populated the datasets only to set their system tags, but these system tags will conflict with existing dataset tags, and we don't want that.

This also reverts #968 , since we want the empty array to be there if no system tag is found for an entity.

🤓 What?

🧪 Tested?

  • Crawler run locally.
  • Modified unit test.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link

github-actions bot commented Sep 5, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11915 10616 89% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/snowflake/extractor.py 85% 🟢
metaphor/snowflake/utils.py 63% 🟢
metaphor/tableau/extractor.py 87% 🟢
TOTAL 78% 🟢

updated for commit: 9465e7f by action🐍

@usefulalgorithm usefulalgorithm merged commit c770e37 into main Sep 5, 2024
4 checks passed
@usefulalgorithm usefulalgorithm deleted the tsung-julii/sc-27944/daily-slack-notifications-for-the-same-governed branch September 5, 2024 17:34
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.09%. Comparing base (112b153) to head (9465e7f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #979      +/-   ##
==========================================
- Coverage   89.10%   89.09%   -0.02%     
==========================================
  Files         184      184              
  Lines       11927    11915      -12     
==========================================
- Hits        10628    10616      -12     
  Misses       1299     1299              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants