Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect all valid query history #975

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

elic-eon
Copy link
Contributor

@elic-eon elic-eon commented Sep 3, 2024

🤔 Why?

Some statements with neither sources nor targets are important allowing us to generate CLL, we should not skip them. In addition, we still want to skip statements like CREATE USER

🤓 What?

  • Add a config process_query.ignore_command_statement
  • Skip commands if it's configured true.
  • Collect other logs

🧪 Tested?

Unit test and ingest MCE to dev.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link

github-actions bot commented Sep 3, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11927 10628 89% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/common/sql/process_query/config.py 100% 🟢
metaphor/common/sql/process_query/process_query.py 87% 🟢
metaphor/postgresql/extractor.py 55% 🟢
TOTAL 81% 🟢

updated for commit: 553a12b by action🐍

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.10%. Comparing base (11612ca) to head (553a12b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #975      +/-   ##
==========================================
+ Coverage   89.05%   89.10%   +0.05%     
==========================================
  Files         184      184              
  Lines       11926    11927       +1     
==========================================
+ Hits        10621    10628       +7     
+ Misses       1305     1299       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elic-eon elic-eon merged commit 75daea1 into main Sep 3, 2024
6 checks passed
@elic-eon elic-eon deleted the scotthuang/sc-28493/collect-all-valid-query-history branch September 3, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants