Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: MCE validation error #974

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

elic-eon
Copy link
Contributor

@elic-eon elic-eon commented Sep 2, 2024

🤔 Why?

Encounter MCE validation when processing the query log.

🤓 What?

The database and schema can not be empty strings or null so add a function to drop query logs that don't have schema

🧪 Tested?

So MCE error after the patch

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

@elic-eon elic-eon requested review from alyiwang, usefulalgorithm and mars-lan and removed request for alyiwang and usefulalgorithm September 2, 2024 16:57
Copy link

github-actions bot commented Sep 2, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11926 10621 89% 85% 🟢

New Files

File Coverage Status
metaphor/common/sql/utils.py 86% 🟢
TOTAL 86% 🟢

Modified Files

File Coverage Status
metaphor/postgresql/extractor.py 55% 🟢
TOTAL 55% 🟢

updated for commit: 47d82f0 by action🐍

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.05%. Comparing base (1dad53e) to head (47d82f0).

Files with missing lines Patch % Lines
metaphor/common/sql/utils.py 85.71% 1 Missing ⚠️
metaphor/postgresql/extractor.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #974      +/-   ##
==========================================
- Coverage   89.06%   89.05%   -0.01%     
==========================================
  Files         183      184       +1     
  Lines       11916    11926      +10     
==========================================
+ Hits        10613    10621       +8     
- Misses       1303     1305       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elic-eon elic-eon enabled auto-merge (squash) September 3, 2024 06:28
@elic-eon elic-eon requested a review from alyiwang September 3, 2024 07:38
@elic-eon elic-eon merged commit 11612ca into main Sep 3, 2024
5 of 6 checks passed
@elic-eon elic-eon deleted the scotthuang/sc-28493/verify-query-parsing-cll branch September 3, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants