Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dbt env platform #972

Merged
merged 4 commits into from
Aug 30, 2024
Merged

Fix dbt env platform #972

merged 4 commits into from
Aug 30, 2024

Conversation

elic-eon
Copy link
Contributor

@elic-eon elic-eon commented Aug 30, 2024

🤔 Why?

Can not directly map the adapter type to DataPlatform

🤓 What?

  • Add a dictionary for the conversion

🧪 Tested?

Run the crawler against an Postgres project in dbt cloud

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

@elic-eon elic-eon enabled auto-merge (squash) August 30, 2024 13:02
@elic-eon elic-eon requested a review from mars-lan August 30, 2024 13:07
Copy link

github-actions bot commented Aug 30, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11886 10589 89% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/dbt/cloud/utils.py 82% 🟢
TOTAL 82% 🟢

updated for commit: 04e444f by action🐍

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.08%. Comparing base (db31024) to head (04e444f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #972      +/-   ##
==========================================
- Coverage   89.09%   89.08%   -0.01%     
==========================================
  Files         183      183              
  Lines       11885    11886       +1     
==========================================
  Hits        10589    10589              
- Misses       1296     1297       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elic-eon elic-eon requested a review from mars-lan August 30, 2024 15:25
@elic-eon elic-eon merged commit 2da563e into main Aug 30, 2024
4 checks passed
@elic-eon elic-eon deleted the fix-dbt-env-platform branch August 30, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants