Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Redshift serverless #960

Merged

Conversation

elic-eon
Copy link
Contributor

@elic-eon elic-eon commented Aug 22, 2024

🤔 Why?

Since Redshift serverless only supports SYS monitoring views we need to migrate our query log fetching SQL to SYS_* view.

Note that we need to grant new permission to get user name from user_id

🤓 What?

As described above, rewrite the query log fetching SQL, and use the util function to get sources and targets.

🧪 Tested?

Verified against Redshift provisioned and Redshift serverless.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link

github-actions bot commented Aug 22, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11819 10493 89% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/oracle/extractor.py 94% 🟢
metaphor/redshift/access_event.py 59% 🟢
metaphor/redshift/extractor.py 72% 🟢
TOTAL 75% 🟢

updated for commit: 0238924 by action🐍

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.78%. Comparing base (de7e290) to head (0238924).
Report is 1 commits behind head on main.

Files Patch % Lines
metaphor/redshift/access_event.py 66.66% 2 Missing ⚠️
metaphor/redshift/extractor.py 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #960      +/-   ##
==========================================
- Coverage   88.78%   88.78%   -0.01%     
==========================================
  Files         182      182              
  Lines       11822    11819       -3     
==========================================
- Hits        10496    10493       -3     
  Misses       1326     1326              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mars-lan mars-lan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fixes

@elic-eon elic-eon merged commit 070b65d into main Aug 22, 2024
4 of 6 checks passed
@elic-eon elic-eon deleted the scotthuang/sc-28218/redshift-serverless-can-t-access-pg-catalog branch August 22, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants