Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sc-28135] Redact literal values in CASE clauses #955

Merged

Conversation

usefulalgorithm
Copy link
Contributor

🤔 Why?

It is possible to have PII values in CASE clauses. Our processor should be able to redact these.

🤓 What?

  • Added logic to redact PII values in CASE clauses.
  • Unit test.
  • Added config value.
  • Updated readme.

🧪 Tested?

Added unit test.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11795 10480 89% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/common/sql/process_query/config.py 100% 🟢
metaphor/common/sql/process_query/process_query.py 88% 🟢
TOTAL 94% 🟢

updated for commit: a872432 by action🐍

@usefulalgorithm usefulalgorithm merged commit 59ac70f into main Aug 19, 2024
4 checks passed
@usefulalgorithm usefulalgorithm deleted the tsung-julii/sc-28135/redact-pii-from-case-in-query-logs branch August 19, 2024 17:03
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.85%. Comparing base (e4d25b4) to head (a872432).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #955   +/-   ##
=======================================
  Coverage   88.84%   88.85%           
=======================================
  Files         182      182           
  Lines       11788    11795    +7     
=======================================
+ Hits        10473    10480    +7     
  Misses       1315     1315           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants