Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip looker user folder hierarchies #948

Merged
merged 9 commits into from
Aug 12, 2024

Conversation

elic-eon
Copy link
Contributor

@elic-eon elic-eon commented Aug 12, 2024

🤔 Why?

We populate all folders as hierarchies, and we should exclude the folder that is not used. So the include_personal_folder flag can also be applied to the hierarchy not just the dashboard.

🤓 What?

  • Refactor build_directory to populate hierarchies as well

🧪 Tested?

Verified no personal folder hierarchy in the output MCEs

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

@elic-eon elic-eon marked this pull request as ready for review August 12, 2024 09:04
Copy link

github-actions bot commented Aug 12, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11764 10452 89% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/looker/extractor.py 63% 🟢
metaphor/looker/folder.py 93% 🟢
TOTAL 78% 🟢

updated for commit: 2592afe by action🐍

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.83%. Comparing base (0d451c2) to head (93fbdb3).

Files Patch % Lines
metaphor/looker/extractor.py 66.66% 1 Missing ⚠️
metaphor/looker/folder.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #948      +/-   ##
==========================================
+ Coverage   88.82%   88.83%   +0.01%     
==========================================
  Files         182      182              
  Lines       11756    11764       +8     
==========================================
+ Hits        10442    10451       +9     
+ Misses       1314     1313       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

elic-eon and others added 2 commits August 12, 2024 18:34
@usefulalgorithm usefulalgorithm self-requested a review August 12, 2024 13:14
Copy link
Contributor

@usefulalgorithm usefulalgorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed a spot

metaphor/looker/folder.py Outdated Show resolved Hide resolved
@usefulalgorithm usefulalgorithm self-requested a review August 12, 2024 16:35
Copy link
Contributor

@usefulalgorithm usefulalgorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go go go

@elic-eon elic-eon enabled auto-merge (squash) August 12, 2024 16:36
@elic-eon elic-eon merged commit cae0807 into main Aug 12, 2024
4 checks passed
@elic-eon elic-eon deleted the scotthuang/sc-28074/skip-looker-user-folder-hierachy branch August 12, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants