-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip looker user folder hierarchies #948
Skip looker user folder hierarchies #948
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #948 +/- ##
==========================================
+ Coverage 88.82% 88.83% +0.01%
==========================================
Files 182 182
Lines 11756 11764 +8
==========================================
+ Hits 10442 10451 +9
+ Misses 1314 1313 -1 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Tsung-Ju Lii <[email protected]>
Co-authored-by: Tsung-Ju Lii <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missed a spot
Co-authored-by: Tsung-Ju Lii <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go go go
🤔 Why?
We populate all folders as hierarchies, and we should exclude the folder that is not used. So the
include_personal_folder
flag can also be applied to the hierarchy not just the dashboard.🤓 What?
build_directory
to populate hierarchies as well🧪 Tested?
Verified no personal folder hierarchy in the output MCEs
☑️ Checks
pyproject.toml
.