-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dedicated folder for looker explores views #944
Dedicated folder for looker explores views #944
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Document this behavior in readme?
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #944 +/- ##
=======================================
Coverage 88.82% 88.82%
=======================================
Files 182 182
Lines 11736 11738 +2
=======================================
+ Hits 10424 10426 +2
Misses 1312 1312 ☔ View full report in Codecov by Sentry. |
I don't think we need to document this in Looker crawler readme. Did you mean document in the code? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
Co-authored-by: Mars Lan <[email protected]>
Co-authored-by: Mars Lan <[email protected]>
Co-authored-by: Mars Lan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
🤔 Why?
To make looker AH cleaner.
🤓 What?
🧪 Tested?
Verified end-to-end
☑️ Checks
pyproject.toml
.