Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedicated folder for looker explores views #944

Merged

Conversation

elic-eon
Copy link
Contributor

@elic-eon elic-eon commented Aug 8, 2024

🤔 Why?

To make looker AH cleaner.

🤓 What?

  • Add a top-level folder for looker explores and views

🧪 Tested?

Verified end-to-end

image

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link
Contributor

@usefulalgorithm usefulalgorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Document this behavior in readme?

Copy link

github-actions bot commented Aug 8, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11738 10426 89% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/looker/config.py 100% 🟢
metaphor/looker/extractor.py 62% 🟢
metaphor/looker/lookml_parser.py 94% 🟢
TOTAL 85% 🟢

updated for commit: ec74da7 by action🐍

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.82%. Comparing base (afe1642) to head (11592c9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #944   +/-   ##
=======================================
  Coverage   88.82%   88.82%           
=======================================
  Files         182      182           
  Lines       11736    11738    +2     
=======================================
+ Hits        10424    10426    +2     
  Misses       1312     1312           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elic-eon
Copy link
Contributor Author

elic-eon commented Aug 8, 2024

Document this behavior in readme?

I don't think we need to document this in Looker crawler readme. Did you mean document in the code?

Copy link
Contributor

@mars-lan mars-lan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

metaphor/looker/lookml_parser.py Outdated Show resolved Hide resolved
mars-lan
mars-lan previously approved these changes Aug 8, 2024
metaphor/looker/README.md Outdated Show resolved Hide resolved
metaphor/looker/README.md Outdated Show resolved Hide resolved
metaphor/looker/config.py Outdated Show resolved Hide resolved
@elic-eon elic-eon requested a review from mars-lan August 8, 2024 17:18
Copy link
Contributor

@mars-lan mars-lan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

metaphor/looker/README.md Outdated Show resolved Hide resolved
@elic-eon elic-eon enabled auto-merge (squash) August 8, 2024 17:40
@elic-eon elic-eon merged commit 3a8b233 into main Aug 8, 2024
6 checks passed
@elic-eon elic-eon deleted the scotthuang/sc-27257/dedicated-folder-for-looker-explores-views branch August 8, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants