Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract owner and description for looker dashboards #943

Conversation

elic-eon
Copy link
Contributor

@elic-eon elic-eon commented Aug 7, 2024

🤔 Why?

  • Get owner information for looker dashboard
  • fill systemDescription field

🤓 What?

As title

🧪 Tested?

Tested end-to-end.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link

github-actions bot commented Aug 7, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11736 10424 89% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/looker/extractor.py 62% 🟢
metaphor/tableau/extractor.py 87% 🟢
metaphor/unity_catalog/extractor.py 97% 🟢
TOTAL 82% 🟢

updated for commit: b167d0e by action🐍

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 10 lines in your changes missing coverage. Please review.

Project coverage is 88.82%. Comparing base (62ce241) to head (b167d0e).

Files Patch % Lines
metaphor/looker/extractor.py 28.57% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #943      +/-   ##
==========================================
- Coverage   88.88%   88.82%   -0.07%     
==========================================
  Files         182      182              
  Lines       11723    11736      +13     
==========================================
+ Hits        10420    10424       +4     
- Misses       1303     1312       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elic-eon elic-eon marked this pull request as ready for review August 7, 2024 16:50
@mars-lan mars-lan merged commit afe1642 into main Aug 7, 2024
4 of 6 checks passed
@mars-lan mars-lan deleted the scotthuang/sc-27776/ingest-owner-description-for-looker-dashboards branch August 7, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants