Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix informatica mapping url #932

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Fix informatica mapping url #932

merged 3 commits into from
Jul 31, 2024

Conversation

elic-eon
Copy link
Contributor

@elic-eon elic-eon commented Jul 31, 2024

🤔 Why?

The URL of INFA mappings is wrong.

🤓 What?

  • use urljoin to get the correct URL

🧪 Tested?

Manually verified the URL in the MCE is correct.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link

github-actions bot commented Jul 31, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11556 10268 89% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/informatica/extractor.py 89% 🟢
TOTAL 89% 🟢

updated for commit: 07b6329 by action🐍

@elic-eon elic-eon enabled auto-merge (squash) July 31, 2024 09:42
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.85%. Comparing base (127ce75) to head (e7472ea).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #932   +/-   ##
=======================================
  Coverage   88.85%   88.85%           
=======================================
  Files         178      178           
  Lines       11556    11556           
=======================================
  Hits        10268    10268           
  Misses       1288     1288           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elic-eon elic-eon disabled auto-merge July 31, 2024 10:22
@elic-eon elic-eon enabled auto-merge (squash) July 31, 2024 10:23
@elic-eon elic-eon merged commit d1e39ee into main Jul 31, 2024
4 checks passed
@elic-eon elic-eon deleted the fix-informatica-mapping-url branch July 31, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants