Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize column names in governance crawler #929

Merged

Conversation

mars-lan
Copy link
Contributor

@mars-lan mars-lan commented Jul 25, 2024

🤔 Why?

We're now normalizing column names to lower cases across the board.

🤓 What?

As titled.

🧪 Tested?

Verified end-to-end:

Screenshot 2024-07-27 at 6 41 48 AM

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link

github-actions bot commented Jul 27, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19850 18603 94% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/custom/governance/config.py 95% 🟢
TOTAL 95% 🟢

updated for commit: 0c8d6d1 by action🐍

@mars-lan mars-lan requested a review from rishimo July 27, 2024 13:42
Copy link

codecov bot commented Jul 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.71%. Comparing base (a17afd9) to head (0c8d6d1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #929      +/-   ##
==========================================
+ Coverage   93.54%   93.71%   +0.17%     
==========================================
  Files         229      182      -47     
  Lines       20033    19850     -183     
==========================================
- Hits        18739    18603     -136     
+ Misses       1294     1247      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mars-lan mars-lan marked this pull request as ready for review July 27, 2024 13:42
@mars-lan mars-lan enabled auto-merge (squash) July 27, 2024 13:43
@mars-lan mars-lan merged commit 8c2b533 into main Jul 27, 2024
6 checks passed
@mars-lan mars-lan deleted the marslan/sc-27761/normalize-column-name-in-custom-governance branch July 27, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants