Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Informatica crawler #928

Merged
merged 10 commits into from
Jul 26, 2024
Merged

Informatica crawler #928

merged 10 commits into from
Jul 26, 2024

Conversation

elic-eon
Copy link
Contributor

@elic-eon elic-eon commented Jul 25, 2024

🤔 Why?

Initial work of extracting Informatica mapping information.

🤓 What?

  • Extract INFA mapping as Pipeline
  • Extract table level lineage from INFA mapping

🧪 Tested?

Verified end-to-end the lineage shows in the app

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link

github-actions bot commented Jul 25, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19850 18603 94% 85% 🟢

New Files

File Coverage Status
metaphor/informatica/config.py 100% 🟢
metaphor/informatica/extractor.py 89% 🟢
metaphor/informatica/models.py 100% 🟢
metaphor/informatica/utils.py 100% 🟢
TOTAL 97% 🟢

Modified Files

File Coverage Status
metaphor/common/api_request.py 88% 🟢
metaphor/fivetran/extractor.py 92% 🟢
metaphor/power_bi/models.py 100% 🟢
metaphor/power_bi/power_bi_client.py 69% 🟢
TOTAL 87% 🟢

updated for commit: 0b9c725 by action🐍

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 92.54902% with 19 lines in your changes missing coverage. Please review.

Project coverage is 93.71%. Comparing base (6b3e716) to head (0b9c725).

Files Patch % Lines
metaphor/informatica/extractor.py 89.18% 16 Missing ⚠️
metaphor/power_bi/power_bi_client.py 50.00% 2 Missing ⚠️
metaphor/common/api_request.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #928      +/-   ##
==========================================
+ Coverage   93.55%   93.71%   +0.16%     
==========================================
  Files         224      182      -42     
  Lines       19791    19850      +59     
==========================================
+ Hits        18515    18603      +88     
+ Misses       1276     1247      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@usefulalgorithm usefulalgorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm. great work!

metaphor/informatica/extractor.py Outdated Show resolved Hide resolved
@elic-eon elic-eon requested a review from usefulalgorithm July 26, 2024 09:36
@elic-eon elic-eon merged commit a17afd9 into main Jul 26, 2024
5 of 6 checks passed
@elic-eon elic-eon deleted the scotthuang/sc-27258/informatica-crawler branch July 26, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants