Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle "Infinity" values returned by DESCRIBE EXTENDED command #927

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

mars-lan
Copy link
Contributor

@mars-lan mars-lan commented Jul 23, 2024

🤔 Why?

#923 didn't handle all the infinity values returned by Unity Catalog's DESCRIBE EXTENDED command, which includes the string literal "Infinity".

🤓 What?

As titled.

🧪 Tested?

Verified against a production instance and inspected the generated MCEs.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link
Contributor

@elic-eon elic-eon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mars-lan mars-lan enabled auto-merge (squash) July 23, 2024 10:55
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19612 18382 94% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/unity_catalog/profile/extractor.py 93% 🟢
TOTAL 93% 🟢

updated for commit: efa7ac8 by action🐍

@mars-lan mars-lan merged commit 6b3e716 into main Jul 23, 2024
4 checks passed
@mars-lan mars-lan deleted the inf branch July 23, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants