Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve service principal owners to their display names #918

Merged
merged 2 commits into from
Jul 20, 2024

Conversation

mars-lan
Copy link
Contributor

🤔 Why?

If a Unity Catalog table is owned by a group, the API will automatically resolve the group's name. However, if the table is owned by a service principal, the API returns its application ID instead.

🤓 What?

Use the API to build a list of service principals and resolve the application ID to the corresponding display name when processing the ownership info.

🧪 Tested?

Verified end-to-end against a production instance.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

@mars-lan mars-lan enabled auto-merge (squash) July 20, 2024 22:18
Copy link
Contributor

@alyiwang alyiwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19321 18110 94% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/unity_catalog/extractor.py 97% 🟢
metaphor/unity_catalog/utils.py 87% 🟢
TOTAL 92% 🟢

updated for commit: 73fc550 by action🐍

Copy link

codecov bot commented Jul 20, 2024

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 93.73%. Comparing base (7dae5ad) to head (73fc550).

Files Patch % Lines
metaphor/unity_catalog/utils.py 78.57% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #918      +/-   ##
==========================================
+ Coverage   93.56%   93.73%   +0.17%     
==========================================
  Files         216      171      -45     
  Lines       19478    19321     -157     
==========================================
- Hits        18224    18110     -114     
+ Misses       1254     1211      -43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mars-lan mars-lan merged commit 0280bf1 into main Jul 20, 2024
5 of 6 checks passed
@mars-lan mars-lan deleted the marslan/sc-27629/resolve-group-ownership-from-uc branch July 20, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants