Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sc-26028] Set default value for entity system tags #848

Conversation

usefulalgorithm
Copy link
Contributor

@usefulalgorithm usefulalgorithm commented Apr 25, 2024

🤔 Why?

Since we can't unset aspects in ingester, we need to give systemTags a default value of SystemTags(tags=[]), so that when the newly created MCE gets ingested, entities that no longer have system tags would get updated correctly.

🤓 What?

Add default value for system tags.

🧪 Tested?

Modified unit test.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link

github-actions bot commented Apr 25, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
18933 17776 94% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/dbt/artifact_parser.py 93% 🟢
metaphor/looker/lookml_parser.py 94% 🟢
metaphor/snowflake/extractor.py 85% 🟢
metaphor/tableau/extractor.py 87% 🟢
metaphor/thought_spot/extractor.py 91% 🟢
metaphor/unity_catalog/extractor.py 96% 🟢
TOTAL 91% 🟢

updated for commit: 0bfe196 by action🐍

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 93.88%. Comparing base (7b0bd80) to head (0bfe196).

Files Patch % Lines
metaphor/snowflake/extractor.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #848      +/-   ##
==========================================
+ Coverage   93.71%   93.88%   +0.17%     
==========================================
  Files         206      163      -43     
  Lines       19105    18933     -172     
==========================================
- Hits        17904    17776     -128     
+ Misses       1201     1157      -44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@usefulalgorithm usefulalgorithm merged commit 168f1cd into main Apr 25, 2024
5 of 6 checks passed
@usefulalgorithm usefulalgorithm deleted the tsung-julii/sc-26028/duplicate-snowflake-tags-for-dim-accounts branch April 25, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants