Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ThoughtSpot directory name #836

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

elic-eon
Copy link
Contributor

@elic-eon elic-eon commented Apr 22, 2024

🤔 Why?

The ThoughtSpot directory is a virtual hierarchy generated from the crawler but we still need to provide the name of the directory in the Hierarchy entity.

🤓 What?

  • Generate 4 hierarchy entities.

🧪 Tested?

Unit tests

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

@elic-eon elic-eon enabled auto-merge (squash) April 22, 2024 16:54
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19019 17830 94% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/thought_spot/extractor.py 91% 🟢
metaphor/thought_spot/utils.py 97% 🟢
TOTAL 94% 🟢

updated for commit: 5f3c2c9 by action🐍

@elic-eon elic-eon merged commit f8c3810 into main Apr 22, 2024
4 checks passed
@elic-eon elic-eon deleted the scotthuang/sc-25585/thoughtspot-hierarchy-is-wired branch April 22, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants