Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not use SHOW SHARES [sc-25711] #832

Merged

Conversation

alyiwang
Copy link
Contributor

🤔 Why?

The SHOW SHARES will return all inbound/outbound shared databases, also including the inbound shared databases that have not been accepted by the receiver.

🤓 What?

  • Not use SHOW SHARES, and use only information_schema instead. This does require the access to the imported databases to be granted to the metaphor role.

🧪 Tested?

tested on metaphor snowflake instance.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

@alyiwang alyiwang enabled auto-merge (squash) April 18, 2024 18:46
Copy link

github-actions bot commented Apr 18, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19015 17827 94% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/snowflake/extractor.py 86% 🟢
TOTAL 86% 🟢

updated for commit: f7379e1 by action🐍

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.75%. Comparing base (8721868) to head (f7379e1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #832      +/-   ##
==========================================
+ Coverage   93.56%   93.75%   +0.18%     
==========================================
  Files         206      163      -43     
  Lines       19190    19015     -175     
==========================================
- Hits        17956    17827     -129     
+ Misses       1234     1188      -46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alyiwang alyiwang requested a review from mars-lan April 18, 2024 21:20
@alyiwang alyiwang merged commit 6dcc32e into main Apr 18, 2024
6 checks passed
@alyiwang alyiwang deleted the yi.wang/sc-25711/snowflake-crawler-no-longer-fetches-tables branch April 18, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants