Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sc-24626] Add query logs MCE count to CrawlerRunMetadata #782

Conversation

usefulalgorithm
Copy link
Contributor

🤔 Why?

Since we've separated the query logs dump logic from the others, we need to also include the query log MCE count in CrawlerRunMetadata.

🤓 What?

Added total_mces_wrote to QueryLogSink, and add that to CrawlerRunMetadata.entity_count.

🧪 Tested?

Unit test.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link

This pull request has been linked to Shortcut Story #24626: Add query log counts to CrawlerRunMetadata.

@usefulalgorithm usefulalgorithm enabled auto-merge (squash) February 20, 2024 15:15
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
15970 14767 92% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/common/file_sink.py 98% 🟢
metaphor/common/runner.py 84% 🟢
TOTAL 91% 🟢

updated for commit: b3eeb87 by action🐍

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0e702ea) 92.26% compared to head (b3eeb87) 92.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #782      +/-   ##
==========================================
+ Coverage   92.26%   92.46%   +0.20%     
==========================================
  Files         197      156      -41     
  Lines       16130    15970     -160     
==========================================
- Hits        14882    14767     -115     
+ Misses       1248     1203      -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@usefulalgorithm usefulalgorithm merged commit 71c0566 into main Feb 20, 2024
6 checks passed
@usefulalgorithm usefulalgorithm deleted the tsung-julii/sc-24626/add-query-log-counts-to-crawlerrunmetadata branch February 20, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants