Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable llm in embed_documents #781

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

rishimo
Copy link
Contributor

@rishimo rishimo commented Feb 12, 2024

🤔 Why?

SC24665

If the llm parameter is not manually disabled or the OPENAI_API_KEY is not configured the ServiceContext becomes very sad.

🤓 What?

Sets llm=None manually to avoid configuring an OPENAI_API_KEY when none is needed.

🧪 Tested?

Tested locally and embeddings are generated successfully.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link

This pull request has been linked to Shortcut Story #24665: explicitly disable llm in embed_documents.

Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
15841 14639 92% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/common/embeddings.py 81% 🟢
TOTAL 81% 🟢

updated for commit: ec5a7b5 by action🐍

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cebe62a) 92.21% compared to head (ec5a7b5) 92.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #781      +/-   ##
==========================================
+ Coverage   92.21%   92.41%   +0.19%     
==========================================
  Files         194      154      -40     
  Lines       16001    15841     -160     
==========================================
- Hits        14756    14639     -117     
+ Misses       1245     1202      -43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rishimo rishimo requested review from prith189 and mars-lan February 12, 2024 22:18
@rishimo rishimo marked this pull request as ready for review February 12, 2024 22:18
@rishimo rishimo merged commit 583f6cd into main Feb 12, 2024
6 checks passed
@rishimo rishimo deleted the rishimohan/sc-24665/explicitly-disable-llm branch February 12, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants