Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture dbt meta field #779

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

mars-lan
Copy link
Contributor

@mars-lan mars-lan commented Feb 9, 2024

🤔 Why?

dbt meta field can contain important metadata.

🤓 What?

As titled.

🧪 Tested?

Verified against a production instance.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link

This pull request has been linked to Shortcut Story #24648: Capture dbt meta field in crawler.

@mars-lan mars-lan enabled auto-merge (squash) February 9, 2024 22:21
Copy link

github-actions bot commented Feb 9, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
15841 14639 92% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/dbt/artifact_parser.py 93% 🟢
TOTAL 93% 🟢

updated for commit: 1e65f34 by action🐍

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (462bc9f) 92.21% compared to head (1e65f34) 92.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #779      +/-   ##
==========================================
+ Coverage   92.21%   92.41%   +0.19%     
==========================================
  Files         194      154      -40     
  Lines       15998    15841     -157     
==========================================
- Hits        14753    14639     -114     
+ Misses       1245     1202      -43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alyiwang alyiwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mars-lan mars-lan merged commit cebe62a into main Feb 9, 2024
6 checks passed
@mars-lan mars-lan deleted the marslan/sc-24648/capture-dbt-meta-field-in-crawler branch February 9, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants