Add title retrieval to Notion crawler #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests so that map_metadata handles the title injection
|
This pull request has been linked to Shortcut Story #24068: Add title to NotionExtractor. |
prith189
reviewed
Jan 24, 2024
….com/MetaphorData/connectors into rishimohan/sc-24068/add-title-notion
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #765 +/- ##
==========================================
+ Coverage 92.07% 92.29% +0.22%
==========================================
Files 194 154 -40
Lines 15899 15758 -141
==========================================
- Hits 14639 14544 -95
+ Misses 1260 1214 -46 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Why?
SC24068
The NotionReader loader from LlamaHub doesn't include functionality to get a page's title, which is useful in generating embeddings and also when returning search results and generated results to users.
🤓 What?
Adds a method to the Notion extractor to retrieve a page's title from the Notion API. The extractor now stores the page title in the document metadata for use later.
Also modifies
map_metadatato prepend the Title to all text nodes.Also includes a couple other fixes (setting _description, _platform, adjusting configuration information).
🧪 Tested?
Unit tests were updated accordingly and ran successfully. Also verified end-to-end with ingestion.
☑️ Checks
pyproject.toml.