Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map MC's MISCONFIGURED status to UNKNOWN #751

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Map MC's MISCONFIGURED status to UNKNOWN #751

merged 1 commit into from
Jan 9, 2024

Conversation

mars-lan
Copy link
Contributor

@mars-lan mars-lan commented Jan 9, 2024

🤔 Why?

[SC-23616]

MISCONFIGURED in Monte Carlo could mean an actual configuration issue or insufficient data for prediction. In either case, it shouldn't be treated as an ERROR.

🤓 What?

As titled.

🧪 Tested?

Manually ran against a production instance.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link

This pull request has been linked to Shortcut Story #23616: Map MC's MISCONFIGURED state to UNKONWN.

Copy link

github-actions bot commented Jan 9, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
15343 14146 92% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/monte_carlo/extractor.py 87% 🟢
TOTAL 87% 🟢

updated for commit: 7992c1c by action🐍

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f23e5bf) 92.01% compared to head (7992c1c) 92.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #751      +/-   ##
==========================================
+ Coverage   92.01%   92.19%   +0.18%     
==========================================
  Files         185      147      -38     
  Lines       15495    15343     -152     
==========================================
- Hits        14257    14146     -111     
+ Misses       1238     1197      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@usefulalgorithm usefulalgorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mars-lan mars-lan merged commit c354d18 into main Jan 9, 2024
6 checks passed
@mars-lan mars-lan deleted the mc branch January 9, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants