Filter dbt cloud jobs by environment id #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #23561: Filter dbt cloud jobs by environment_id. |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #749 +/- ##
==========================================
+ Coverage 92.01% 92.19% +0.18%
==========================================
Files 185 147 -38
Lines 15495 15354 -141
==========================================
- Hits 14257 14156 -101
+ Misses 1238 1198 -40 ☔ View full report in Codecov by Sentry. |
|
Yikes, merged another PR into this one and now there's a lot of changes :/ |
Rebase? |
Argh I see. You didn't create #750 against main. |
This reverts commit 1be0df8.
mars-lan
reviewed
Jan 9, 2024
mars-lan
previously approved these changes
Jan 10, 2024
mars-lan
approved these changes
Jan 10, 2024
usefulalgorithm
deleted the
tsung-julii/sc-23561/filter-dbt-cloud-jobs-by-environment-id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Why?
To filter collected dbt jobs by their environment ID.
🤓 What?
If user specified a list of environment ids to include, and the crawler sees a job with an environment id not in that list, then the job will be ignored.
🧪 Tested?
☑️ Checks
pyproject.toml.